stream: reject closed only after sink abort settles - #65727
Open
lazerg wants to merge 1 commit into
Open
Conversation
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
Sep 1, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65727 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01%
==========================================
Files 754 754
Lines 256395 256402 +7
Branches 48494 48508 +14
==========================================
+ Hits 230947 230951 +4
- Misses 16563 16576 +13
+ Partials 8885 8875 -10
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The writer's
closedpromise is materialized lazily, and the lazy derivation maps a stream in the'errored'state straight to an already rejected promise.WritableStreamFinishErroringsets that state before it runs the sink'sabort(), so aclosedpromise first observed inside that window comes back rejected while the sink is still tearing down. The spec only rejects it fromWritableStreamRejectCloseAndClosedPromiseIfNeeded, in the reaction to the abort algorithm.The closed records are now materialized as pending right before the abort algorithm runs, so the existing settle sites reject them at the point the spec does.
Fixes: #65726